mbien commented on code in PR #4450:
URL: https://github.com/apache/netbeans/pull/4450#discussion_r970254398
##########
nbbuild/javadoctools/template.xml:
##########
@@ -280,23 +279,36 @@ cause it to fail.
<!-- Timestamp is handled in javadoc.css to avoid too many commits on
generated HTML files. -->
<property name="javadoc.footer" value='<span
class="footnote"></span><!-- See javadoc.css for timestamp
information -->'/>
</target>
-
- <target name="javadoc-exec-packages"
depends="javadoc-init,javadoc-generate-references,javadoc-generate-overview,javadoc-exec-condition,javadoc-check-timestamps,javadoc-make-plain-title,javadoc-make-hyperlinked-title,javadoc-exec-condition,-javadoc-set-footer"
unless="javadoc.exec.packages">
- <javadoc source="${javac.source}" author="false"
destdir="${javadoc.out.dir}" packagenames="${javadoc.packages}"
stylesheetfile="${javadoc.css.main}" windowtitle="${javadoc.title}"
overview="${javadoc.overview}" splitindex="true" use="true" version="false"
useexternalfile="true" encoding="UTF-8">
+
+
+ <target name="-javadoc-exec-packages-nbjavac"
depends="javadoc-init,javadoc-generate-references,javadoc-generate-overview,javadoc-exec-condition,javadoc-check-timestamps,javadoc-make-plain-title,javadoc-make-hyperlinked-title,javadoc-exec-condition,-javadoc-set-footer"
if="javadoc.nbjavac">
+ <property name="javadoc.source" value="11" />
+ <javadoc source="${javadoc.source}" verbose="false" failonerror="true"
author="false" destdir="${javadoc.out.dir}" packagenames="${javadoc.packages}"
stylesheetfile="${javadoc.css.main}" windowtitle="${javadoc.title}"
overview="${javadoc.overview}" splitindex="true" use="true" version="false"
useexternalfile="false" encoding="UTF-8">
+ <!--<arg
value="-J-Xbootclasspath/a:${nb_all}/java/libs.javacapi/externa
l/nb-javac-jdk-18.0.1+10.jar:${nb_all}/java/libs.javacapi/external/nb-javac-jdk-18.0.1+10-api.jar"
/-->
+ <!--
${nb_all}/java/libs.javacapi/external/nb-javac-jdk-18.0.1+10.jar"/ -->
+ <arg
line="--patch-module=jdk.compiler=${nb_all}/java/libs.javacapi/external/nb-javac-jdk-18.0.1+10-api.jar:${nb_all}/java/libs.javacapi/external/nb-javac-jdk-18.0.1+10.jar"
/>
+ <arg
line="--patch-module=java.compiler=${nb_all}/java/libs.javacapi/external/nb-javac-jdk-18.0.1+10-api.jar:${nb_all}/java/libs.javacapi/external/nb-javac-jdk-18.0.1+10.jar"
/>
Review Comment:
this would be another path we have to update with each javac upgrade :(.
Master is already using nb-javac 19 btw, so this would probably fail if you
sync this PR again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
