sdedic commented on code in PR #4450:
URL: https://github.com/apache/netbeans/pull/4450#discussion_r970509944
##########
extide/gradle/src/org/netbeans/modules/gradle/api/execute/GradleExecConfiguration.java:
##########
@@ -52,7 +52,7 @@
* </div>
* <p>
* GradleExecConfigurations can be also declared by a Plugin that implements a
- * <a
href="@TOP@/org/netbeans/spi/GradleActionsProvider.html#define-configuration">GradleActionsProvider</a>,
+ * {@link org.netbeans.modules.gradle.spi.actions.GradleActionsProvider
GradleActionsProvider },
Review Comment:
The original link points directly to the example code (using anchor)
##########
enterprise/j2eeserver/src/org/netbeans/modules/j2ee/deployment/devmodules/api/J2eePlatform.java:
##########
@@ -509,8 +509,8 @@ public Set<Profile> getSupportedProfiles() {
/**
* Returns the set of supported profiles (terminology of Java EE 6) for
* the given module type (one of {@link J2eeModule#EAR},
- * {@link J2eeModule#EJB}, {@link J2eeModule#WAR}, {@link J2eeModule#RAR}
- * and {@link J2eeModule#CAR}).
+ * {@link J2eeModule#EJB}, {@link J2eeModule#WAR}, {@link J2eeModule#CONN}
Review Comment:
CONN and CLIENT are deprecated in the `J2eeModule` ?
##########
harness/nbjunit/src/org/netbeans/junit/NbModuleSuite.java:
##########
@@ -273,7 +273,7 @@ Configuration classLoader(ClassLoader parent) {
/** Adds new test name, or array of names into the configuration. By
* default the suite executes all <code>testXYZ</code>
* methods present in the test class
- * (the one passed into {@link Configuration#create(java.lang.Class)}
+ * (the one passed into {@code
NbModuleSuite.Configuration#create(java.lang.Class)}
Review Comment:
should be a @link - because of the "#" syntax ?
##########
enterprise/j2eeserver/src/org/netbeans/modules/j2ee/deployment/plugins/spi/J2eePlatformImpl.java:
##########
@@ -178,7 +178,7 @@ public Set<Profile> getSupportedProfiles() {
/**
* Returns a set of supported profiles for the given module type
* (one of {@link J2eeModule#EAR}, {@link J2eeModule#EJB},
- * {@link J2eeModule#WAR}, {@link J2eeModule#RAR} and {@link
J2eeModule#CAR}).
+ * {@link J2eeModule#WAR}, {@link J2eeModule#CONN} and {@link
J2eeModule#CLIENT}).
Review Comment:
CLIENT is deprecated -- OK ?
##########
extide/gradle/src/org/netbeans/modules/gradle/api/execute/ActionMapping.java:
##########
@@ -26,8 +26,7 @@
* Mapping for IDE actions to Gradle command line.
* <p>
* The mapping can cause the action to be <b>disabled</b>: if {@link
#getReloadRule()} == {@link ReloadRule#NEVER} and
- * {@link #getArgs()} == {@code null}. Such mapping had no effect in previous
versions. This can be checked by a
- * convenience method {@link RunUtils#isActionDisabled}.
+ * {@link #getArgs()} == {@code null}. Such mapping had no effect in previous
versions.
Review Comment:
reason to remove the mention to isActionDisabled ?
##########
ide/api.debugger/src/org/netbeans/api/debugger/ActionsManager.java:
##########
@@ -164,7 +164,7 @@ public final void doAction (final Object action) {
/**
* Post action on this DebuggerEngine.
* This method does not block till the action is done,
- * if {@link #canPostAsynchronously} returns true.
+ * if <code>canPostAsynchronously</code> returns true.
Review Comment:
better @link to the method ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
