mbien commented on code in PR #4648:
URL: https://github.com/apache/netbeans/pull/4648#discussion_r976867040


##########
java/java.source.base/src/org/netbeans/modules/java/source/save/Reformatter.java:
##########
@@ -1151,7 +1151,7 @@ public Boolean visitVariable(VariableTree node, Void p) {
                                 newline();
                             else
                                 space();
-                        } else {
+                        } else if (sp.getStartPosition(root, mods) != 
sp.getStartPosition(root, node.getType())) {

Review Comment:
   thats what i feared :(
   
   This means we can hotfix this as you proposed, but it is possible that it 
might break again since the behavior is not really specified.
   
   Maybe there is a chance for an upstream update @jlahoda? Another 
return-constant or possibly documented behavior of what is returned for 
"hidden" elements.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to