mbien commented on code in PR #4648:
URL: https://github.com/apache/netbeans/pull/4648#discussion_r976959934
##########
java/java.source.base/src/org/netbeans/modules/java/source/save/Reformatter.java:
##########
@@ -1151,7 +1151,7 @@ public Boolean visitVariable(VariableTree node, Void p) {
newline();
else
space();
- } else {
+ } else if (sp.getStartPosition(root, mods) !=
sp.getStartPosition(root, node.getType())) {
Review Comment:
>The hotfix shouldn't break if this is fixed. And it's covered by tests now
I think. Could add a comment to revert when upstream fixed?
Yeah I think so - lets get this in. The tests are indeed important so that
we notice regressions quickly. Good that you found that bug report, it clears
things up.
If the upstream fix makes it into javac 19.0.1 too, we could
adjust/partially revert it later while upgrading nb-javac.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
