errael commented on PR #4739: URL: https://github.com/apache/netbeans/pull/4739#issuecomment-1270508111
> bypass NetBeans' APIs! grimacing I wonder if it's worth the effort of rewriting them? The current situation is a hassle, it happens enough to be anoying, but not enough to be the first thing I check (that's changing). I thought about saying something like "this could be viewed as an interim step, fixing bugs, until <some kind of rewrite>". The last sentence of the initial comment does suggest that things weren't done right, and implies that it should be handled better. I saw FileChooserBuilder, that method `findDialogParent` could be put somewhere public, maybe `DialogDisplayer`, and I could rerun jackpot with that. But then there's a testing problem, I don't know how to force most of those dialogs. But I believe that would be better than the current state, and maybe not as reliable as this current PR. I'm suspect about `findDialogParent` picking the last frame in the list. I don't trust KeyboardFocusManager.getActiveWindow. I think it returns null at inconvenient times, see https://github.com/apache/netbeans/pull/4714#issue-1393511869 third paragraph. I've been thinking about a patch to DialogDisplayerImpl that handles a null return from KeyboardFocusManager.getActiveWindow and makes a choice. I can't imagine where else incorrect placement of the dialogs could be coming from. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
