mbien commented on PR #4739: URL: https://github.com/apache/netbeans/pull/4739#issuecomment-1271009878
> > the class that opens the dialog is itself an instance of `java.awt.Component`. In that case it could be passed to `JFileChooser#show*Dialog` > > Yes, that would be best. This PR is about automatically fixing obvious bugs. I mean this inspection affects 30 files or so. I think a second manual pass would be realistic to fix those occurrences which apply. There is also the [inClass(String... classes)](https://netbeans.apache.org/jackpot/HintsFileFormat.html#_standard_conditions) condition which could help here if you want to automate that too (I haven't used that one yet myself, it doesn't work for interfaces that I know), however I believe doing this manually is going to be faster (since we already know the occurences) than scanning all projects again (which can take a bit). If you decide to do that manually, maybe also consider reducing the whitespace changes in the imports. Since they add empty lines in between every top level package change - this only makes sense if the imports are actually sorted ;) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
