mbien commented on code in PR #4817:
URL: https://github.com/apache/netbeans/pull/4817#discussion_r1014735005
##########
.github/workflows/main.yml:
##########
@@ -91,6 +109,13 @@ jobs:
key: ${{ runner.os }}-${{ hashFiles('*/external/binaries-list',
'*/*/external/binaries-list') }}
restore-keys: ${{ runner.os }}-
+ - name: Setup Gradle Daemon to run on JDK 11
+ if: ${{ matrix.java > 18 }}
+ run: |
+ mkdir -p ~/.gradle
+ #uses a preinstalled JDK 11 from the runner
+ echo "org.gradle.java.home=$JAVA_HOME_11_X64" >>
~/.gradle/gradle.properties
Review Comment:
this allows us to build on JDK 19+ too.
Its unclear why building locally on JDK 19 works perfectly fine without
having to configure the daemon to run somewhere else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
