matthiasblaesing commented on PR #4817: URL: https://github.com/apache/netbeans/pull/4817#issuecomment-1307814317
Instead of changing the code in `db.mysql` let's please update the dependency of connector/j. I updated it to the current version 8.0.31 and unittests run clean. The real fix was somewhere between 8.0.17 and 8.0.20, but as newest runs on JDK 8-19 I think this is better. It is also low risk, as this is a pure unittest depdency. The size of the changeset is purely created by update license file. [db.mysql.bump.connectorj.patch.zip](https://github.com/apache/netbeans/files/9965156/db.mysql.bump.connectorj.patch.zip) The "real" change is this (yes connector/j switch groupIds): ```patch matthias@enterprise:~/src/netbeans$ git diff ide/db.mysql/external/binaries-list ide/db.mysql/nbproject/project.properties diff --git a/ide/db.mysql/external/binaries-list b/ide/db.mysql/external/binaries-list index a0c50ecfccc5..323f53cc6e24 100644 --- a/ide/db.mysql/external/binaries-list +++ b/ide/db.mysql/external/binaries-list @@ -15,4 +15,4 @@ # specific language governing permissions and limitations # under the License. -53DA6AFDC5F7B45CAAA5BC3627028B2041A36CEE mysql:mysql-connector-java:8.0.17 +3FD5850719D7E82D50705D34CC6A0037FAB5731F com.mysql:mysql-connector-j:8.0.31 diff --git a/ide/db.mysql/nbproject/project.properties b/ide/db.mysql/nbproject/project.properties index 61702569949e..4668ce59ff94 100644 --- a/ide/db.mysql/nbproject/project.properties +++ b/ide/db.mysql/nbproject/project.properties @@ -18,4 +18,4 @@ javac.source=1.8 javac.compilerargs=-Xlint -Xlint:-serial spec.version.base=0.47.0 -test.unit.cp.extra=external/mysql-connector-java-8.0.17.jar +test.unit.cp.extra=external/mysql-connector-j-8.0.31.jar matthias@enterprise:~/src/netbeans$ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
