mbien commented on code in PR #5138: URL: https://github.com/apache/netbeans/pull/5138#discussion_r1056670162
########## java/java.completion/nbproject/project.properties: ########## @@ -31,3 +31,6 @@ test.timeout=1200000 # requires nb.javac for compiling of tests on Mac requires.nb.javac=true + +test.jms.flags=--limit-modules=java.base,java.logging,java.xml,java.prefs,java.desktop,java.management,java.instrument,jdk.zipfs,java.scripting,java.naming +test.bootclasspath.prepend.args=-Dno.netbeans.bootclasspath.prepend.needed=true Review Comment: this has almost the same effect as the old CI config line: ``` OPTS_11=-Dtest.run.args=--limit-modules=java.base,java.logging,java.xml,java.prefs,java.desktop,java.management,java.instrument,jdk.zipfs,java.scripting,java.naming -Dtest.bootclasspath.prepend.args=-Dno.netbeans.bootclasspath.prepend.needed=true ``` the difference is that the entire run args property isn't overwritten which is set up here: https://github.com/apache/netbeans/blob/30a8cefa5a73f258b61939729e845672e66826fe/nbbuild/templates/projectized.xml#L293 this has however has the side effect of warnings like: `WARNING: Unknown module: jdk.compiler specified to --add-exports` I am wondering if i should set `metabuild.jms-flags.jvm` to an empty string in the project configs? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
