mbien commented on code in PR #5138: URL: https://github.com/apache/netbeans/pull/5138#discussion_r1056861917
########## java/java.completion/nbproject/project.properties: ########## @@ -31,3 +31,6 @@ test.timeout=1200000 # requires nb.javac for compiling of tests on Mac requires.nb.javac=true + +test.jms.flags=--limit-modules=java.base,java.logging,java.xml,java.prefs,java.desktop,java.management,java.instrument,jdk.zipfs,java.scripting,java.naming +test.bootclasspath.prepend.args=-Dno.netbeans.bootclasspath.prepend.needed=true Review Comment: actually, i got an idea while waiting for Santa. we can simply unset the default flags of the compiler category: ``` # remove default compiler JMS flags so that we don't get "Unknown module" warnings due to --limit-modules jms-compiler.flags.jvm= ``` since we did put them into categories already (#3658) we may as well make use of that fact :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
