mbien commented on PR #5335: URL: https://github.com/apache/netbeans/pull/5335#issuecomment-1399481151
> If we don't do anything about the dialog size, then vertically centering the icons improves the appearance of the dialogs. to me it marginally improves the look of a **certain** type of dialog: one line messages On the [screenshot](https://github.com/apache/netbeans/pull/5335#issue-1551528823) you provided, both before and after windows look to me as if someone placed labels on a frame without bothering to configure the layout or frame size. Both do look unfinished. > If we do fix the dialog size, then the cases where vertically centering the icon looks bad go away. It makes the situation worse for already existing dialogs which display [more content](https://github.com/apache/netbeans/pull/5335#issuecomment-1399358156). Fixing the size there would still have the icon centered which looks non-standard. This is of course just my opinion. However, I do believe that it is fairly common to anchor an icon to the NW corner in dialogs. I can see the same layout in the master pw window of thunderbird or firefox for example:  another example is the standard gnome keychain unlock dialog:  Since this UI pattern works for both, small dialogs and big dialogs, it probably became popular and also made it into JDK's dialog utilities. I don't see it as a bug, the bug appears to be the incorrect sizing of the content inserted right from the icon which causes this weird behavior since the window can't pack correctly. A 1 line label isn't 90 pixels tall, yet it is what its preferred size is for some reason and someone [tried to fix this before](https://github.com/apache/netbeans/pull/5335#issuecomment-1399353457). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
