eirikbakke commented on PR #5335: URL: https://github.com/apache/netbeans/pull/5335#issuecomment-1484225136
I pushed a new adjustment to this PR, which adds some top margin to the icon instead of vertically centering it. The specific margin height is chosen so that the icon ends up appearing centered next to single-line messages while appearing (almost) top-aligned next to taller messages:  <img width="257" alt="longer" src="https://user-images.githubusercontent.com/886243/227804557-d64d9d09-3e4a-4448-9575-68403341faaf.png";> With @mbien's adjustments from https://github.com/apache/netbeans/pull/5625 , the minimum height of the dialog also ends up a little smaller (note: only the top screenshot above includes the latter adjustment; I'm not sure where in NetBeans I can easily trigger a taller dialog for testing), and single-line messages end up looking more vertically centered than before. After trying various values for the minimum height, I ended up preferring a value of 50, which happened to be the value already in place. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
![https://user-images.githubusercontent.com/886243/227804557-d64d9d09-3e4a-4448-9575-68403341faaf.png"](https://user-images.githubusercontent.com/886243/227804557-d64d9d09-3e4a-4448-9575-68403341faaf.png"){kind=link}