lkishalmi commented on code in PR #5297: URL: https://github.com/apache/netbeans/pull/5297#discussion_r1084551281
########## ide/languages.go/licenseinfo.xml: ########## @@ -0,0 +1,27 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + +--> +<licenseinfo> + <fileset> + <file>src/org/netbeans/modules/languages/go/resources/go-blue.png</file> + <license ref="CC-BY-4.0" /> Review Comment: @matthiasblaesing I've just re-read the license and the ASF 3rd Party License policy. It seems the best would be to create an icon of our own. The main issue I see here, is that this image is modified (resized) work, in which case we should abide to the share-alike clause, which we can't do in ASF. Unmodified work could be included. I've tried to use the original SVG, but NetBeans does not like that one. Unfortunately, I'm really clumsy with graphics stuff, other than resizing. The TOML file icon is about my limit. So I'd be happy if you could type that 2 letters. (A 16x16 PNG is needed with transparent background) I think the selected blue would fit both light and dark LaF-s. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
