matthiasblaesing commented on code in PR #5297: URL: https://github.com/apache/netbeans/pull/5297#discussion_r1095102165
########## ide/languages.go/licenseinfo.xml: ########## @@ -0,0 +1,27 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + +--> +<licenseinfo> + <fileset> + <file>src/org/netbeans/modules/languages/go/resources/go-blue.png</file> + <license ref="CC-BY-4.0" /> Review Comment: Done: https://github.com/matthiasblaesing/netbeans/commit/437391c84b3178ee5533488e1a98c56a88633224 I documented how the "logo" was created in the SVG. I noticed a warning when starting (registration of GoLanguage collides with antlr3 grammar one). This is my fix: https://github.com/matthiasblaesing/netbeans/commit/50955a9a8a71dfac214be650ae69b5adda147f2c Feel free to pull changes from https://github.com/matthiasblaesing/netbeans/commits/pr-5297 and squash them into your work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
