pepness opened a new pull request, #5444: URL: https://github.com/apache/netbeans/pull/5444
I did some cleaning to the `j2ee.persistence` module with the `Inspect & Transform` tool. I reviewed each suggestion of the inspection tool with special emphasis on lambdas and try-with-resources and made sure not to break something. After this I plan to improve the JPA support to 2.2 or hopefully 3.1. - Use lambdas when possible (like new Runnable or calling an async task with RequestProcessor) - Use try-with-resources - Use URI.toURL() instead of new URL() - Use Utilities.toURI method - Use NbBundle.getMessage instead of NbBundle.getBundle - Remove redundant if expressions and if statements - if-else and loops statements should use braces - Remove unnecessary continue and return statements - Use Exception constructor when possible - Use multi-catch - Unnecessary boxing and primitive instantiation - Use diamond inference on declaration-initialization - Use generics - Use switch expression - Remove unused logger - Remove imports from the same package - Remove unused imports - Add missing Override annotations - Fix some typos - Fix some formatting - Add a TODO comment I did full builds and fix the errors that pop out. NetBeans Testing: - Full build done (with each commit) - Verify successful execution of libraries and licenses Ant test - Verify successful execution of Verify Sigtests - Verify successful execution of unit tests for module `j2ee.persistence` - Started NetBeans and ensure the log didn't have any ERROR or new WARNINGS - Successfully create different persistence units in different application servers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
