pepness commented on code in PR #5444:
URL: https://github.com/apache/netbeans/pull/5444#discussion_r1099537657
##########
java/j2ee.persistence/src/org/netbeans/modules/j2ee/persistence/provider/ProviderUtil.java:
##########
@@ -161,8 +162,8 @@ private static Provider getContainerManagedProvider(Project
project) {
* @param pu the persistence unit whose database connection is to
* be retrieved; must not be null.
*
- * @return the connection specified in the given persistence unit or
- * <code>null</code> if it didn't specify a connectioh.
+ * @rerturn the connection specified in the given persistence unit or
Review Comment:
Done.
##########
java/j2ee.persistence/src/org/netbeans/modules/j2ee/persistence/entitygenerator/SQLType.java:
##########
@@ -145,8 +148,8 @@ private Class getClassForCharType (Integer length, boolean
isNullable) {
// the no-arg getMemberType method are sufficient
private Class getClassForNumericType(Integer precision,
Integer scale, boolean isNullable) {
- int precValue = ((precision == null) ? -1 : precision.intValue());
- int scaleValue = ((scale == null) ? -1 : scale.intValue());
+ int precValue = ((precision == null) ? -1 : precision);
+ int scaleValue = ((scale == null) ? -1 : scale);
Review Comment:
Done.
##########
java/j2ee.persistence/src/org/netbeans/modules/j2ee/persistence/editor/completion/db/DBCompletionContextResolver.java:
##########
@@ -661,9 +685,13 @@ private List
completeManyToMany(JPACodeCompletionProvider.Context ctx, CCParser.
element:
for(VariableElement f : resultFields) {
for(javax.lang.model.element.Modifier
mod:f.getModifiers()){
-
if(javax.lang.model.element.Modifier.TRANSIENT.equals(mod))continue element;
+
if(javax.lang.model.element.Modifier.TRANSIENT.equals(mod)) {
+ continue element;
+ }
+ }
+
if(JpaControllerUtil.isAnnotatedWith(f,"javax.persistence.Transient")) {
+ continue;//NOI18N
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
