mbien commented on PR #5444: URL: https://github.com/apache/netbeans/pull/5444#issuecomment-1422047801
just a general comment: converting big blocks into lambdas basically loses the git blame history of the whole block. So I am not sure how useful that is all things considered. Maybe we shouldn't keep doing this in future. (Maybe consider reverting the largest candidates?) Converting single char Strings into chars to use a different String method variant is also a stylistic change which has no runtime benefits anymore. Probably something we can skip over in future too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
