troizet commented on code in PR #5475:
URL: https://github.com/apache/netbeans/pull/5475#discussion_r1107257853
##########
php/php.editor/src/org/netbeans/modules/php/editor/verification/UnusableTypesHintError.java:
##########
@@ -576,11 +574,10 @@ private void createRedundantTypeCombinationError(ASTNode
node, UnionType unionTy
private void createIterableRedundantTypeCombinationError(UnionType
unionType, IterableRedundantTypeCombination.RedundantType redundantType) {
hints.add(new IterableRedundantTypeCombination(rule, fileObject,
unionType.getStartOffset(), unionType.getEndOffset(), unionType,
redundantType));
}
-
- private static boolean isArrayType(Identifier identifier) {
- return !identifier.isKeyword()
- &&
Type.ARRAY.equals(identifier.getName().toLowerCase(Locale.ENGLISH));
- }
+
Review Comment:
Done.
##########
php/php.editor/src/org/netbeans/modules/php/editor/verification/UnusableTypesHintError.java:
##########
@@ -590,7 +587,7 @@ private static boolean isCallableType(Identifier
identifier) {
private static boolean isVoidType(NamespaceName namespaceName) {
return
Type.VOID.equals(CodeUtils.extractUnqualifiedName(namespaceName));
}
-
+
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
