junichi11 commented on code in PR #5475:
URL: https://github.com/apache/netbeans/pull/5475#discussion_r1109780618
##########
php/php.editor/tools/ASTPHP5Parser.cup:
##########
@@ -2625,10 +2625,9 @@ fully_qualified_class_name:className
RESULT = className;
:}
-| T_ARRAY:array
+| T_ARRAY:name
{:
- Identifier classId = new Identifier(arrayleft, arrayright, "array");
- RESULT = classId;
+ RESULT = NamespaceName.create(nameleft, nameright, name);
Review Comment:
`string` is recognized as a namespace name with #4037
https://github.com/apache/netbeans/blob/1d85a3e854fafef563a3b0986b88f4e9613a1d85/php/php.editor/tools/ASTPHP5Parser.cup#L4323-L4348
So, this should be OK, I think.
If we come across a problem, let's fix it. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
