neilcsmith-net commented on code in PR #5568:
URL: https://github.com/apache/netbeans/pull/5568#discussion_r1119183124
##########
nbbuild/build.xml:
##########
@@ -19,7 +19,7 @@
under the License.
-->
-<project name="nbbuild" default="build-nozip" basedir="." xmlns:if="ant:if"
xmlns:unless="ant:unless">
+<project name="nbbuild" default="build" basedir="." xmlns:if="ant:if"
xmlns:unless="ant:unless">
Review Comment:
I'm not too bothered either way, as long as the build instructions are
updated in the readme to reflect that an end user who wants to build from
source needs to use `ant build` and should use the zip. That's how we ended up
with JavaFX in the Snap at one point!
I don't necessarily agree the default needs to change. It depends how much
we expect an end user to expect `ant` to do the right thing for them? Funnily
enough, when developing NetBeans I always end up running `ant build` out of
habit anyway...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
