mbien commented on code in PR #5568:
URL: https://github.com/apache/netbeans/pull/5568#discussion_r1119211618


##########
nbbuild/build.xml:
##########
@@ -19,7 +19,7 @@
     under the License.
 
 -->
-<project name="nbbuild" default="build-nozip" basedir="." xmlns:if="ant:if" 
xmlns:unless="ant:unless">
+<project name="nbbuild" default="build" basedir="." xmlns:if="ant:if" 
xmlns:unless="ant:unless">

Review Comment:
   @matthiasblaesing i don't care either way tbh. I always use `ant 
build-nozip` in my scripts and even CI uses that since I honestly always 
thought that the default would produce a zip, but as @neilcsmith-net mentioned 
at 
https://github.com/apache/netbeans-website/pull/643#pullrequestreview-1314473064
 we have to either update the README or the default target.
   
   I let you two decide, just tell me what to do :)
   
   as I mentioned in 
https://github.com/apache/netbeans/pull/5568#issuecomment-1446222425, this was 
mostly a test run to check if changing the default would break something in CI.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to