vieiro commented on PR #5598: URL: https://github.com/apache/netbeans/pull/5598#issuecomment-1454858767
> I agree that I need to run tests. I found how I can do it today. But I had a number of questions. Is it enough to run the command: ant test? There are many kind of tests, ranging from unit tests to functional tests. Post a question in the mailing list to get some guidance, or consult the tutorials. Note that the comments I've added are only those I found in a quick review. You're expected to review **all of the rest of changes** in these few hundred files, and make sure that: * you're not changing APIs/SPIs, * that all form you're changing can be opened in the IDE (this is, that Java code is in sync with the corresponding form and Bundle files). * that all tests pass in the affected modules. * that you can run the IDE (`ant tryme`) and that the forms that you've changed are working properly (this is, that no exception is thrown making the IDE or the form unusable). Once you've done all these changes and tests then: * squash the commits (`git rebase -i` may be of help) * and then force push to this same branch (`git push -f`). * Then ask for another review again. We expect you're focused in this PR, making it pristine for our review, and that you won't open any other new PRs that do not match these quality criteria. The goal of all this work is to have a new version of NetBeans that behaves **exactly the same** for end users (because users won't notice that you have renamed internal variables, because you have made sure that all tests work, and because you have made sure that forms don't break). Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
