vieiro commented on PR #5598: URL: https://github.com/apache/netbeans/pull/5598#issuecomment-1468757235
Hi @tbw777 , So we don't really want to correct typos in source code/comments that are not visible to the user. We prefer to focus the reviewers effort in things that have more impact on end users (solving bugs, adding new features, etc.). After all users don't bother what we name internal variables. Modifying tests without understanding them is also problematic, as you could see for yourself tests take long time to run (specially PHP, which is tested thoroughly). Modifying test files to correct typos may alter the internal indexes we use in these files (specially in editor features) and may make tests to fail. So what about closing this one and moving onto the next PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
