mbien commented on code in PR #5673:
URL: https://github.com/apache/netbeans/pull/5673#discussion_r1140888554
##########
java/maven.indexer/src/org/netbeans/modules/maven/indexer/NexusRepositoryIndexerImpl.java:
##########
@@ -653,7 +653,7 @@ private static boolean isDiag() {
//spawn the indexing into a separate thread..
private boolean spawnIndexLoadedRepo(final RepositoryInfo repo) {
- if (!RepositoryPreferences.isIndexDownloadEnabled() &&
repo.isRemoteDownloadable()) {
+ if (!RepositoryPreferences.isIndexDownloadEnabledEffective() &&
repo.isRemoteDownloadable()) {
Review Comment:
I don't think this is correct. This would disable local indexing too if
downloads are off.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
