matthiasblaesing commented on PR #5673:
URL: https://github.com/apache/netbeans/pull/5673#issuecomment-1474775286

   > why do we want to retain the download setting if indexing is turned off 
completely?
   
   Because a user could use this setting to temporarily prevent maven index 
downloading to burn through his CPU. If I uncheck on setting and $other setting 
is changed as a side effect and not automatically changed back, I as a user 
would be very surprised.
   
   To turn off maven indexing, I have a single click, to return to the previous 
setting I have to do multiple clicks. Why?
   
   > I don't like it that the grayed out check box can be still shown as 
selected with this approach. I think this sends the wrong message through the 
UI. That is the reason why the options window itself unchecked that box. This 
does also make sense settings wise - for me at least. 
![index-settings-off](https://user-images.githubusercontent.com/114367/226077892-2b960df6-4b6e-4756-bfac-d048d9055a67.png)
   
   I disagree here. The checkbox still reflects the value the user (or the 
default) set. It just becomes meaningless, because the feature is turned of 
completly.
   
   I think this new behavior is in line with other instances in options:
   
   - The configuration values for multi-row tabs retain their value, when 
disabled and show it to the user:
   
![image](https://user-images.githubusercontent.com/2179736/226095054-5623b644-8d83-48e8-9934-c15c16dca3a7.png)
   - Code folding retains the value of the collapse settings when code folding 
is not enabled:
   
![image](https://user-images.githubusercontent.com/2179736/226095128-37e2210c-0dce-4645-985f-98f684145a43.png)
   - Hightlighting does the same:
   
![image](https://user-images.githubusercontent.com/2179736/226095168-0f35b007-eae5-42e4-bfc6-07f4550e5c07.png)
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to