junichi11 commented on code in PR #5681: URL: https://github.com/apache/netbeans/pull/5681#discussion_r1141490463
########## php/php.editor/test/unit/data/testfiles/actions/testNB4978/01/testNB4978_01.php.fixUses: ########## @@ -23,8 +23,6 @@ declare (strict_types=1); namespace TestNamespace; -use Foo\Foo\Foo; Review Comment: > To have Fix Imports working for the whole file I had to add scope to UsedNamesCollector's names and it also affected some tests, because for now it is important that DataItems from ImportDataCreator were paired with Selections, but previously Selection could be imported without real DataItem. We fixed this once, so, it would be recognized as a regression, I think... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
