rossluk commented on code in PR #5681:
URL: https://github.com/apache/netbeans/pull/5681#discussion_r1142729957
##########
php/php.editor/src/org/netbeans/modules/php/editor/model/impl/ModelBuilder.java:
##########
@@ -86,7 +86,7 @@ class ModelBuilder {
NamespaceScope build(NamespaceDeclaration node, OccurenceBuilder
occurencesBuilder) {
final NamespaceDeclarationInfo info =
NamespaceDeclarationInfo.create(node);
- NamespaceScopeImpl nScope = (info.isDefaultNamespace()) ?
defaultNamespaceScope : ModelElementFactory.create(info, this);
+ NamespaceScopeImpl nScope = /*(info.isDefaultNamespace()) ?
defaultNamespaceScope :*/ ModelElementFactory.create(info, this);
Review Comment:
This is actually the fix for multiple default namespaces in navigator and
for proper default namespaces OffsetRange. I left it commented only if in a
near feature something will go wrong with this to give a clue to someone who
will debug this. Should I remove the comment or do you need more deep
explanation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
