sdedic commented on code in PR #5679:
URL: https://github.com/apache/netbeans/pull/5679#discussion_r1141959366
##########
java/maven/src/org/netbeans/modules/maven/execute/MavenProxySupport.java:
##########
@@ -935,7 +949,11 @@ public int next() throws XmlPullParserException,
IOException {
private LineAndColumn startPos() {
int ln = getLineNumber();
int col = getColumnNumber();
- col -= (posEnd - posStart);
+ try {
+ col -= (posEndField.getInt(this) - posStartField.getInt(this));
+ } catch (IllegalAccessException ex) {
+ Exceptions.printStackTrace(ex);
+ }
Review Comment:
This whole thing is triggered when:
- maven `settings.xml` specifies a proxy
- the system does not use a proxy (so no http*_proxy env var or reachable
PAC file)
- a maven build or priming build is triggered, or other request in 'online'
mode.
I will try to create a simple unittest to verify the settings.xml parsing
produces the expected results.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
