sdedic commented on code in PR #5679:
URL: https://github.com/apache/netbeans/pull/5679#discussion_r1144324983
##########
java/maven/build.xml:
##########
@@ -56,8 +56,8 @@
<!-- we use jarjar to repackage simple json, to avoid clashes with 3rd
party maven plugins possibly including it in their dependencies -->
<taskdef name="jarjar" classname="org.pantsbuild.jarjar.JarJarTask"
loaderref="lib.path.loader">
<classpath>
- <pathelement location="./external/asm-7.0.jar"/>
- <pathelement location="./external/asm-commons-7.0.jar"/>
+ <pathelement location="./external/asm-9.4.jar"/>
Review Comment:
Question: asm is provided in platform/libs.asm too, but it seems that since
its version is driven by jarjar, it's better to have a separate compile-time
external here ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
