javierllorente commented on PR #21:
URL:
https://github.com/apache/netbeans-nbpackage/pull/21#issuecomment-1480299465
> > Content below `%files` in `rpm.spec.template` needs to be removed.
>
> What content? `${RPM_FILE}` is literally the newly calculated file list.
That should be there as far as I know. It can't be empty?
There is a list of hard-coded files/directories in the current
[`rpm.spec.template`](https://github.com/apache/netbeans-nbpackage/blob/master/src/main/resources/org/apache/netbeans/nbpackage/rpm/rpm.spec.template).
With your change, that list is no longer needed; it is generated dynamically.
> > I am not seeing any call to broom action. Besides `*.exe`, I would also
remove `*.bat` and `*.dll` and clean the following directories: `
/usr/lib/apache-netbeans/ide/bin/nativeexecution/` `
/usr/lib/apache-netbeans/profiler/remote-pack-defs/`
>
> There will be no default removal. You can set it in configuration files
using `package.remove=<PATTERN>` or on the command line with
`-Premove=<PATTERN>`. For that you would use
`{*.exe,*.bat,*.dll,**/nativeexecution/MacOSX-*/*, .... }`. See also the glob
patterns for macOS signing, which cover some of the same files -
https://github.com/apache/netbeans-nbpackage/blob/master/src/main/java/org/apache/netbeans/nbpackage/macos/MacOS.java#L31
Understood. Then that remove pattern you mention should be used for the next
NetBeans release rpm/deb package.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
