neilcsmith-net commented on PR #21:
URL: 
https://github.com/apache/netbeans-nbpackage/pull/21#issuecomment-1480336155

   > There is a list of hard-coded files/directories in the current 
[`rpm.spec.template`](https://github.com/apache/netbeans-nbpackage/blob/master/src/main/resources/org/apache/netbeans/nbpackage/rpm/rpm.spec.template).
 With your change, that list is no longer needed; it is generated dynamically.
   
   Yes, that should be changed already in 
https://github.com/apache/netbeans-nbpackage/pull/21/files#diff-6a712fcb595d56bad2e1385e8c83c209fb3d20ffcefb05f87f9ca2f264b6b0cd
   
   > Then that remove pattern you mention should be used for the next NetBeans 
release rpm/deb package.
   
   I wasn't planning to propose that change. Could possibly be discussed but 
there are benefits to keeping the zip contents intact too. Obviously you could 
build packages with this that do filter out whatever you don't want to include.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to