neilcsmith-net commented on PR #5762: URL: https://github.com/apache/netbeans/pull/5762#issuecomment-1493279417
> > There are better ways to approach this issue, if we actually need to. > > What would that be? Redrawing all the icons? Well, yes, that is obviously the ideal! There is a limit to what can be done after the fact, or automated. Other options are to look for the most problematic icons and provide dark alternatives - I don't think the majority of the icons _are_ actually a problem. _If_ we really want an image filter, other options could be explored, such as filtering using colour distance from background colour, or a lookup table to an alternative palette (although that might involve some posterization). The key thing is that value inversion looks alien - great if that's the intended effect - it's not possible to ignore colour theory and perception in how people interpret these things though. > The style for the new SVG icons (written up at https://issues.apache.org/jira/browse/NETBEANS-2617 ) avoids the problem of inverted depth, by getting rid of the shadow/highlight detail that were present in the old bitmap icons. This is part of it. Ideally we'd make sure the palette is based on an alterable stylesheet, so that the colours can be corrected when first converted from SVG to a bitmap rather than assuming we can reliably do this at a later stage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
