jlahoda opened a new pull request, #5763:
URL: https://github.com/apache/netbeans/pull/5763
When a watch contains a binding variable, it fails to show the value. This
patch is trying to fix that - that's the `case BINDING_VARIABLE:` change.
In addition to this, this patch is trying to:
- add a test for the change, that will only execute under JDK 17.
- run debugger.jpda tests on JDK 11 and JDK 17
- disabling tests that failed for me locally - I used a fairly coarse way
to disable them, so that e.g. in `EvaluationTest`, only one subtest fails. This
could, presumably, be improved in further patches. IMO better to run some
tests, than none.
- the `info.getCompilationUnit()` -> `treePath.getCompilationUnit()` change
is a bit tricky: if scanning is running, the TreePath may originate in a
different javac instance than is the one held in `info`. Which then leads to
end position `-1` (because the end position is held into CompilationUnitTree,
but only for trees under that top-level tree), which will inject code at
incorrect place. Using `treePath.getCompilationUnit()` is not 100% correct, I
think, but it workarounds the issue at this specific place, at least
---
**^Add meaningful description above**
By opening a pull request you confirm that, unless explicitly stated
otherwise, the changes -
- are all your own work, and you have the right to contribute them.
- are contributed solely under the terms and conditions of the Apache
License 2.0 (see section 5 of the license for more information).
Please make sure (eg. `git log`) that all commits have a valid name and
email address for you in the Author field.
If you're a first time contributor, see the Contributing guidelines for more
information.
If you're a committer, please label the PR before pressing "Create pull
request" so that the right test jobs can run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
