vieiro commented on PR #5764: URL: https://github.com/apache/netbeans/pull/5764#issuecomment-1495817419
> Agreed. I weep a little every time I see a hard-coded `Color` in the NetBeans code. smile Was just looking at this, and wondering where to tap in to configure these - LAF and editor themes could be relevant, although probably should also go through https://github.com/apache/netbeans/blob/master/platform/core.output2/src/org/netbeans/core/output2/options/OutputOptions.java > Well, since these are standard ANSI colors I don't think it's a good idea to let the user configure them. We may still hard code some sensible values, that honor the current theme (the defaults you point to look like a good starting point). By the way, it seems we're using `UIManager.getBoolean("nb.dark.theme")` to check for a dark theme, right? We may want to wrap that idiom around an API in the future, too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
