neilcsmith-net commented on PR #5764: URL: https://github.com/apache/netbeans/pull/5764#issuecomment-1496234829
> since these are standard ANSI colors I don't think it's a good idea to let the user configure them. Well, the GNOME terminal lets me configure the palette. I'm not going to second guess why people might want to configure, for example [this](https://www.bloomberg.com/ux/2021/10/14/designing-the-terminal-for-color-accessibility/) came up while looking for an example (good examples, different terminal!) We could use colour options in Look and Feels though - at least for FlatLaf, any property can now be overridden via the UI as a fallback option. > By the way, it seems we're using `UIManager.getBoolean("nb.dark.theme")` to check for a dark theme, right? We may want to wrap that idiom around an API in the future, too. I have mixed feelings about that - in some ways it's almost as bad as hard coding colours in the first place. Better to have an API that says "give me the shade of red, blue, green, etc. that works with the current theme". I may look at that - similar question has come up in at least two other places recently! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
