jlahoda commented on code in PR #5802:
URL: https://github.com/apache/netbeans/pull/5802#discussion_r1167617973
##########
java/ant.hints/src/org/netbeans/modules/ant/hints/errors/EnablePreviewAntProj.java:
##########
@@ -195,7 +166,7 @@ public EditableProperties run() throws IOException {
}
}
- private boolean isAntProject(Project prj) {
+ private static boolean isAntProject(Project prj) {
if (prj == null) {
Review Comment:
Well, `FileOwnerQuery.getOwner` can return `null`. So, there must be a null
check somewhere. I don't really see an advantage in doing that before calling
the method? Is there some? (Frankly, even if the method was public, I'd
probably make it accept nulls, to make its use as convenient as possible, so
that callers would not have to additionally check for `null`. I am not sure
what's the issue with a method checking for `null`.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
