mbien commented on code in PR #5802:
URL: https://github.com/apache/netbeans/pull/5802#discussion_r1168043195
##########
java/maven.hints/src/org/netbeans/modules/maven/hints/errors/EnablePreviewMavenProj.java:
##########
@@ -245,18 +182,36 @@ private Configuration createConfiguration() {
}
private Plugin updateMavenCompilerPlugin(final Plugin oldPlugin) {
-
Configuration currenConfig = oldPlugin.getConfiguration();
+ Plugin newPlugin = factory.createPlugin();
+ newPlugin.setGroupId(oldPlugin.getGroupId());
+ newPlugin.setArtifactId(oldPlugin.getArtifactId());
+ newPlugin.setVersion(oldPlugin.getVersion());
+
newPlugin.setConfiguration(updateMavenCompilerPluginConfiguration(currenConfig));
+ return newPlugin;
+ }
+
+ private Configuration updateMavenCompilerPluginConfiguration(final
Configuration currenConfig) {
Configuration newConfiguration = createConfiguration();
- boolean isCompilerArgsElementPresent = false;
if (currenConfig != null) {
+ boolean isCompilerArgsElementPresent = false;
+ boolean isSourceElementPresent = false;
+ boolean isTargetElementPresent = false;
for (POMExtensibilityElement element :
currenConfig.getConfigurationElements()) {
POMExtensibilityElement newElement =
factory.createPOMExtensibilityElement(element.getQName());
String elementText = element.getElementText();
if (elementText.trim().length() > 0) {
newElement.setElementText(element.getElementText());
}
+ if (newElement.getQName().getLocalPart().equals(SOURCE) &&
newSourceLevel != null) {
+ newElement.setElementText(newSourceLevel);
+ isSourceElementPresent = true;
+ }
+ if (newElement.getQName().getLocalPart().equals(TARGET) &&
newSourceLevel != null) {
+ newElement.setElementText(newSourceLevel);
+ isTargetElementPresent = true;
+ }
Review Comment:
this looks like it would break if the compiler plugin is using `release`
already, since it isn't compatible with `source`+`target`.
Should be an easy fix though, just another `if`
actually, ~I am pretty sure there is a utility somewhere which does this
already.~ Let me take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
