mbien commented on code in PR #5876:
URL: https://github.com/apache/netbeans/pull/5876#discussion_r1175671022
##########
java/maven/src/org/netbeans/modules/maven/customizer/CompilePanel.java:
##########
@@ -162,15 +166,18 @@ public Boolean getValue() {
public void setValue(Boolean v) {
handle.removePOMModification(operation);
modifiedValue = null;
- String value = v != null ? (v ? "all" : "none") : "all";
+ boolean cosEnabled = v != null ? v : getDefaultValue();
+ String value = cosEnabled ? "all" : "none";
Review Comment:
if we set this to:
`String value = cosEnabled ? "all" : null;`
it would remove the property entirely (and the file too) if it is turned off.
CheckBoxUpdater isn't setting the bold/plain setting properly, but this is a
problem for all check boxes in this panel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
