matthiasblaesing opened a new pull request, #5877:
URL: https://github.com/apache/netbeans/pull/5877
While running NetBeans with assertions enabled, while tryping to open the
detail/value dialog for the "String value", an AssertionError was observed.
```
java.lang.AssertionError: Debugger lock taken in AWT Event Queue!
at
org.netbeans.modules.debugger.jpda.JPDADebuggerImpl$DebuggerReentrantReadWriteLock$DebuggerReadLock.lock(JPDADebuggerImpl.java:2710)
at
org.netbeans.modules.debugger.jpda.models.JPDAThreadImpl$ThreadReentrantReadWriteLock$ThreadWriteLock.lock(JPDAThreadImpl.java:2581)
at
org.netbeans.modules.debugger.jpda.JPDADebuggerImpl.invokeMethod(JPDADebuggerImpl.java:1080)
at
org.netbeans.modules.debugger.jpda.JPDADebuggerImpl.invokeMethod(JPDADebuggerImpl.java:1022)
at
org.netbeans.modules.debugger.jpda.models.AbstractObjectVariable.getToStringValue(AbstractObjectVariable.java:500)
at
org.netbeans.modules.debugger.jpda.models.AbstractObjectVariable.getToStringValue(AbstractObjectVariable.java:464)
at
org.netbeans.modules.debugger.jpda.models.AbstractObjectVariable.getToStringValue(AbstractObjectVariable.java:428)
at
org.netbeans.modules.debugger.jpda.ui.models.VariablesTableModel.getValueAt(VariablesTableModel.java:108)
at
org.netbeans.spi.viewmodel.Models$DelegatingTableModel.getValueAt(Models.java:2249)
at
org.netbeans.modules.debugger.jpda.ui.models.NumericDisplayFilter.getValueAt(NumericDisplayFilter.java:112)
at
org.netbeans.spi.viewmodel.Models$CompoundTableModel.getValueAt(Models.java:1439)
at
org.netbeans.modules.debugger.jpda.ui.models.VariablesTreeModelFilter.getValueAt(VariablesTreeModelFilter.java:530)
at
org.netbeans.spi.viewmodel.Models$CompoundTableModel.getValueAt(Models.java:1439)
at
org.netbeans.modules.debugger.jpda.ui.models.EvaluatorTableModelFilter.getValueAt(EvaluatorTableModelFilter.java:71)
at
org.netbeans.spi.viewmodel.Models$CompoundTableModel.getValueAt(Models.java:1439)
at
org.netbeans.spi.viewmodel.Models$CompoundTableModel.getValueAt(Models.java:1441)
at
org.netbeans.spi.viewmodel.Models$CompoundTableModel.getValueAt(Models.java:1441)
at
org.netbeans.spi.viewmodel.Models$CompoundModel.getValueAt(Models.java:4565)
at
org.netbeans.modules.viewmodel.TreeModelNode$MyProperty.updateShortDescription(TreeModelNode.java:2094)
at
org.netbeans.modules.viewmodel.TreeModelNode$MyProperty.getShortDescription(TreeModelNode.java:2076)
at
org.openide.explorer.propertysheet.CustomEditorAction.actionPerformed(CustomEditorAction.java:290)
at
org.openide.explorer.propertysheet.PropertyPanel$CustomEditorProxyAction.actionPerformed(PropertyPanel.java:1199)
at
org.openide.explorer.view.OutlineView$OutlineViewOutline.editCellAt(OutlineView.java:2115)
at
java.desktop/javax.swing.plaf.basic.BasicTableUI$Handler.adjustSelection(BasicTableUI.java:1147)
at
java.desktop/javax.swing.plaf.basic.BasicTableUI$Handler.mousePressed(BasicTableUI.java:1077)
```
Indeed here the call comes from the EDT and directly tries to access the
JPDA connection.
The fix is inspired from JPDAAsynchronousModel and moves value fetching from
the EDT to the JPDA thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists