jlahoda commented on PR #5802: URL: https://github.com/apache/netbeans/pull/5802#issuecomment-1524694522
> changes look good. > > I added commits here: https://github.com/mbien/netbeans/commits/better-enable-preview > > this adds a fix for compiler plugins without groupID (groupIds are optional for standard maven plugins) and rudimentary support for `pluginManagement`. Tests included. > > feel free to squash with your changes if you like it (I can do this too if you are ok with me me force pushing into your PR). Thanks for the changes. Not sure if it is allowed to squash commits from different authors, though. I believe it is not. I'll work on including your patches. I need to take a look at the action in VS Code, though, as it didn't work for me yesterday. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
