matthiasblaesing commented on code in PR #5802:
URL: https://github.com/apache/netbeans/pull/5802#discussion_r1169194633
##########
java/maven.hints/src/org/netbeans/modules/maven/hints/errors/EnablePreviewMavenProj.java:
##########
@@ -245,18 +182,36 @@ private Configuration createConfiguration() {
}
private Plugin updateMavenCompilerPlugin(final Plugin oldPlugin) {
-
Configuration currenConfig = oldPlugin.getConfiguration();
+ Plugin newPlugin = factory.createPlugin();
+ newPlugin.setGroupId(oldPlugin.getGroupId());
+ newPlugin.setArtifactId(oldPlugin.getArtifactId());
+ newPlugin.setVersion(oldPlugin.getVersion());
+
newPlugin.setConfiguration(updateMavenCompilerPluginConfiguration(currenConfig));
+ return newPlugin;
+ }
+
+ private Configuration updateMavenCompilerPluginConfiguration(final
Configuration currenConfig) {
Configuration newConfiguration = createConfiguration();
- boolean isCompilerArgsElementPresent = false;
if (currenConfig != null) {
+ boolean isCompilerArgsElementPresent = false;
+ boolean isSourceElementPresent = false;
+ boolean isTargetElementPresent = false;
for (POMExtensibilityElement element :
currenConfig.getConfigurationElements()) {
POMExtensibilityElement newElement =
factory.createPOMExtensibilityElement(element.getQName());
String elementText = element.getElementText();
if (elementText.trim().length() > 0) {
newElement.setElementText(element.getElementText());
}
+ if (newElement.getQName().getLocalPart().equals(SOURCE) &&
newSourceLevel != null) {
+ newElement.setElementText(newSourceLevel);
+ isSourceElementPresent = true;
+ }
+ if (newElement.getQName().getLocalPart().equals(TARGET) &&
newSourceLevel != null) {
+ newElement.setElementText(newSourceLevel);
+ isTargetElementPresent = true;
+ }
Review Comment:
Yes, I got that. But this PR goes through multiple modules in an area I did
not yet touch. The suggested changes seem sane, but that is much as I'm willing
to say tonight, what I don't get is why the rush now? Is there a reason to
force it in now or could @jlahoda just finish it and it gets into NB19?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
