notzed commented on PR #5897:
URL: https://github.com/apache/netbeans/pull/5897#issuecomment-1528898421
I applied your patch as suggested - now the setting appears to do nothing
whatsoever.
Just to clarify these are the relevant pre-patch options I use:
> [ ] auto popup completion window
> [x] auto popup documentation window
> [ ] display documentation next to window
> [ ] insert single proposes automatically
I have this function:
> /**
> * Blah
> * @param a
> * @param b
> * @param c
> */
> static void foo(int a, int b, int c) {
>
> }
In some other piece of code I type:
> foo[ctrl-space]
to get:
So far so good, this lets me navigate matches and review the documentation,
etc.
I then hit [return] to select the function I want (i.e. foo(a,b,c)):
And that pops up. This is what I want to remove as it almost always covers
important context i'm using to fill out the parameters and even if it doesn't
it's distracting and annoying.
With your patch the new option makes no difference here, it just always
shows up.
Not that it's a deal-breaker but I also don't think the text should include
'auto' because this is not related to the automatic setting. Nor is the 'auto
popup documentation window' as indicated by the source comment '// Show
documentation as well if set by default'. They are both in effect: 'if showing
completion (whether automatically or not), then also show documentation, and/or
also show parameters'.
Infact the behaviour desired is the same as the show-documentation checkbox,
although they display at different times so the same mechanism can't be
utilised.
Through the debugger I found it is invoked from:
java/java.editor/src/org/netbeans/modules/editor/java/JavaCompletionItem.java
I've pushed a work-in-progress patch that creates the behaviour I want
whilst retaining ctrl-p behaviour. I don't know about other languages though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
