notzed commented on PR #5897: URL: https://github.com/apache/netbeans/pull/5897#issuecomment-1539094961
Just wondering if there is any follow-up here. Last week I force-pushed a change. As I commented above I tried your patch but it just didn't work for me and I moved the invocation test to the java completion code which is the only place that knows where the request came from. With the new patch the option behaves the same as the 'documentation auto-popup' one, i.e. it only pops up 'as well as' the completion when enabled, but doesn't affect explicit requests (i.e. C-p). I fixed the whitespace but the main caveat with the new patch is that it retains it as an all-languages option (which seems the right place?) but I only implemented it in the java completion code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
