tmysik commented on PR #5900: URL: https://github.com/apache/netbeans/pull/5900#issuecomment-1534302714
@rossluk First of all - respect for this PR, it is definitely not trivial, and you did a lot of work, thanks for it! @junichi11 Since this PR is very big, I am not sure whether we can review it properly; therefore, I would suggest this - could you, please: - try to understand the big picture of this change and whether it makes sense to you; - verify that this PR cannot break any other area; and - review all the updated and new tests, whether they are correct? I will try to do the same but frankly, my knowledge is quite limited, it is already a long time :sweat_smile: In general, I am not against this change if all the tests are still passing and newly added tests make sense (and cover the change nicely). The question is, how maintainable the code will be - will it be better or worse in comparison to the current state? Based on the initial description, it should be better, I hope :grin: Please, give me some time, so I can try to understand the change, at least a bit :smile: Thank you both! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
