junichi11 commented on PR #5900: URL: https://github.com/apache/netbeans/pull/5900#issuecomment-1534466796
@tmysik Thank you for your advice and help :) I just looked at the changes. So, I need more time to understand them. > In general, I am not against this change if all the tests are still passing and newly added tests make sense (and cover the change nicely). Yes, I agree with this. > The question is, how maintainable the code will be My concern is this. If it's hard to maintain, we need to improve this, I think. @rossluk Thank you for working on this :) I'll read the code later when I have time. So, let's improve this with us little by little. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
