ebarboni commented on code in PR #5936:
URL: https://github.com/apache/netbeans/pull/5936#discussion_r1192210871
##########
java/maven.embedder/external/binariesembedded-list:
##########
@@ -17,44 +17,44 @@
0235BA8B489512805AC13A8F9EA77A1CA5EBE3E8;org.aopalliance:aopalliance:1.0
1194890E6F56EC29177673F2F12D0B8E627DEC98;org.apache.httpcomponents:httpclient:4.5.14
-7F2E0C573EAA7A74BAC2E89B359E1F73D92A0A1D;org.apache.httpcomponents:httpcore:4.5.15
+51CF043C87253C9F58B539C9F7E44C8894223850;org.apache.httpcomponents:httpcore:4.4.16
Review Comment:
It's release critical (for platform maven users), and good findings to get
it before release.
pom from org-netbeans-modules-maven-embedder-RELEASE180 contains that (from
zip in ci build)
<dependency>
<groupId>org.apache.httpcomponents</groupId>
<artifactId>httpcore</artifactId>
<version>4.5.15</version>
<classifier></classifier>
</dependency>
and thats not good will lead to issue for user later after release. Because
not everyone is using that dependency.
I fully aggree for additional tooling.
Also may want to auto stage on release build if possible as it's apache /
apache so we may have early test. (Snapshot are not exacly the same tree as the
populating of snapshot is not limited to release cluster)
So additionnal build could have a integration test application to check all
clusters pom.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
