mbien commented on code in PR #5936:
URL: https://github.com/apache/netbeans/pull/5936#discussion_r1194979010
##########
java/maven.embedder/build.xml:
##########
@@ -21,16 +21,13 @@
-->
<project basedir="." default="build" name="java/maven.embedder">
<import file="../../nbbuild/templates/projectized.xml"/>
- <target name="-release.files" depends="projectized.-release.files">
+ <target name="-release.files"
depends="projectized.-release.files,check-binariesembedded-list">
Review Comment:
I tested the list manually with this:
https://github.com/apache/netbeans/pull/5939#issuecomment-1545628713
we should think about the whole approach a bit more since this doesn't feel
right to me. Instead of validating the list after doing an error prone manual
update we should think about generating it from
https://github.com/apache/maven/blob/master/pom.xml or something equivalent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
