asbachb commented on code in PR #6096:
URL: https://github.com/apache/netbeans/pull/6096#discussion_r1246166625
##########
enterprise/web.jsf.editor/src/org/netbeans/modules/web/jsf/editor/completion/JsfAttributesCompletionHelper.java:
##########
@@ -461,7 +462,7 @@ public static void
completeFaceletsFromProject(CompletionContext context, List<C
public static void completeXMLNSAttribute(CompletionContext context,
List<CompletionItem> items, JsfSupportImpl jsfs) {
if
(context.getAttributeName().toLowerCase(Locale.ENGLISH).startsWith("xmlns")) {
//NOI18N
//xml namespace completion for facelets namespaces
- Set<String> nss =
NamespaceUtils.getAvailableNss(jsfs.getLibraries(), jsfs.isJsf22Plus());
+ Set<String> nss =
NamespaceUtils.getAvailableNss(jsfs.getLibraries(),
jsfs.getJsfVersion().isAtLeast(JsfVersion.JSF_2_2));
Review Comment:
I guess you're right.
Just for more context: Actually I was focusing on getting the functionality
working mentioned in the isssue as I know what I can test. I did not do a all
over the place, ensure that jsf 4 is supported refactoring.
I think this should be adjusted as well, but I'm not aware about the
consequences and how to validate that behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
