matthiasblaesing commented on code in PR #6096:
URL: https://github.com/apache/netbeans/pull/6096#discussion_r1246988150
##########
enterprise/web.jsf.editor/src/org/netbeans/modules/web/jsf/editor/completion/JsfAttributesCompletionHelper.java:
##########
@@ -461,7 +462,7 @@ public static void
completeFaceletsFromProject(CompletionContext context, List<C
public static void completeXMLNSAttribute(CompletionContext context,
List<CompletionItem> items, JsfSupportImpl jsfs) {
if
(context.getAttributeName().toLowerCase(Locale.ENGLISH).startsWith("xmlns")) {
//NOI18N
//xml namespace completion for facelets namespaces
- Set<String> nss =
NamespaceUtils.getAvailableNss(jsfs.getLibraries(), jsfs.isJsf22Plus());
+ Set<String> nss =
NamespaceUtils.getAvailableNss(jsfs.getLibraries(),
jsfs.getJsfVersion().isAtLeast(JsfVersion.JSF_2_2));
Review Comment:
This method is invoced when you have this situation:
```xml
<f:view
xmlns="http://www.w3.org/1999/xhtml";
xmlns:c="http:|"
</f:view>
```
The caret/cursor is placed at the location marked with "|" and you call for
completion (I have mapped that to CTRL+Space. You should get a list of
supported libraries/namespaces (screenshot from a project based on JSF 2.2):
You can see, that both the legacy namespaces and the "jcp" namespaces are
returned. The order should be reversed from my POV, but that is a separate
discussion. In a JSF4 project I would expect all namespaces as already
described.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
