neilcsmith-net commented on code in PR #6294:
URL: https://github.com/apache/netbeans/pull/6294#discussion_r1283424875
##########
platform/core.windows/src/org/netbeans/core/windows/services/NbPresenter.java:
##########
@@ -1599,7 +1584,10 @@ private Window findFocusedWindow() {
}
}
}
- while( null != w && !w.isShowing() ) {
+ while( null != w ) {
+ if ((w instanceof Frame || w instanceof Dialog) && w.isShowing()) {
+ break;
+ }
Review Comment:
This was a deliberate, if ancillary, addition. While testing the problem, I
noticed the bounds of the dialog are wrong (and on another screen for me)
because it's using the popup window that was being found as parent. Dialog from
status bar button equivalent is in the right place. So added the same
parenting logic here to work out what to calculate bounds from.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
